Pulled out app paths to separate config and added a check for required files in start script #113
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
christophior
force-pushed
the
master
branch
2 times, most recently
from
a190ba9 to
6b77dae
Compare
ghost
added
the
christophior
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Both myself and @lacker have the issue of npm install -g react-native not working. Would be awesome to investigate and figure out why |
|
@vjeux interesting, when I start working on this again i'll look into that issue as well. |
…d files in start script
|
By the way I started making the path change (although in a different way) in #191. |
|
I’m going to close this because it got out of date. We still need help on #96 so please feel free to resubmit focusing on that feature in particular. |
|
Makes sense, the portions of the changes (path changes) seem to already be made so i'll look into the changes and try making another PR that solely focuses on fixing the issue if no one is already pursuing #96. |
remove typePatches
PR is still a work in progress mainly because for some reason installing the module globally on my local machine to test was not working and even installing the module from npm doesn't work so I haven't really been able to test this -_-
I keep getting a prompt saying that the
create-react-appcommand is not found.Anyways...
I also feel like I should add some logic where the browser doesn't attempt to open if there are any missing required files, maybe don't even compile if any files are missing.
Referencing issue #96
If someone wants to build on top of this PR feel free too as well, just leave a comment below in case I or someone else wants to continue this.